Re-enable C++/CLI test coverage previously gated on VS 2026 toolset availability#54558
Open
Copilot wants to merge 2 commits into
Open
Re-enable C++/CLI test coverage previously gated on VS 2026 toolset availability#54558Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix C++/CLI tests failing on VS 2026 Helix machines
Re-enable C++/CLI test coverage previously gated on VS 2026 toolset availability
Jun 2, 2026
marcpopMSFT
approved these changes
Jun 2, 2026
Member
|
These were disabled in main and servicing, then reenabled in main, then codeflow disabled them again. Let's try reenabling. |
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables previously skipped C++/CLI test coverage across Build/Pack/Publish test suites by removing temporary Skip metadata that was added due to missing VC toolset availability on VS 2026 Helix scout images.
Changes:
- Removed
Skip = "https://github.com/dotnet/sdk/issues/53789"fromFullMSBuildOnlyFact-gated C++/CLI Build tests. - Removed the same
Skipfrom the C++/CLI Pack and Publish coverage tests. - Re-enabled the C++-related SourceLink test by removing the temporary skip.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishACppCliProject.cs | Removes temporary skip to re-enable the C++/CLI publish scenario test. |
| test/Microsoft.NET.Pack.Tests/GivenThatWeWantToPackACppCliProject.cs | Removes temporary skip to re-enable the C++/CLI pack scenario test. |
| test/Microsoft.NET.Build.Tests/SourceLinkTests.cs | Removes temporary skip to re-enable the C++ SourceLink test. |
| test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.cs | Removes temporary skips to re-enable transitive-deps C++/CLI build validations. |
| test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProject.cs | Removes temporary skips to re-enable core C++/CLI build coverage scenarios. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VS 2026 Helix scout queues were failing C++/CLI coverage because tests were broadly disabled behind a temporary skip tied to missing VC tooling. This change removes those temporary disables so the C++/CLI scenarios execute again now that the image/tooling issue has been addressed.
Re-enable Build test suite C++/CLI coverage
Skipfrom allFullMSBuildOnlyFacttests in:GivenThatWeWantToBuildACppCliProjectGivenThatWeWantToBuildACppCliProjectWithTransitiveDepsSourceLinkTests.CppRe-enable Pack C++/CLI coverage
SkipfromGivenThatWeWantToPackACppCliProject.It_cannot_pack_the_cppcliproject.Re-enable Publish C++/CLI coverage
SkipfromGivenThatWeWantToPublishACppCliProject.When_referenced_by_csharp_project_it_publishes_and_runs.Change shape