[clr-ios] Pass references hidden from the composite to crossgen2 when building a partial composite#54576
Closed
kotlarmilos wants to merge 1 commit into
Closed
[clr-ios] Pass references hidden from the composite to crossgen2 when building a partial composite#54576kotlarmilos wants to merge 1 commit into
kotlarmilos wants to merge 1 commit into
Conversation
… building a partial composite When publishing a composite R2R image that covers only a subset of the closure (e.g. only System.Private.CoreLib, with the rest excluded via PublishReadyToRunExclude), PrepareForReadyToRunCompilation flags the excluded assemblies as HideReferenceFromComposite and drops them from ReadyToRunCompositeBuildReferences, so crossgen2 receives no -r references and CoreCLR rejects the resulting image at startup (FailFast in NativeImage::Open). Include those references in the composite reference list; they remain valid -r references and only need to be excluded from being composite inputs, which is already enforced by the existing !eligibility.Compile check, making the change behavior-preserving for the full-composite case while fixing partial composites. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
3 tasks
Member
Author
|
Instead of excluding the non-CoreLib BCL assemblies and passing them back to crossgen2 as hidden composite references, now roots the composite on System.Private.CoreLib only and keeps the remaining framework assemblies as unrooted composite inputs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When publishing a composite R2R image that covers only a subset of the BCL (e.g. only
System.Private.CoreLib, with the rest excluded viaPublishReadyToRunExclude),PrepareForReadyToRunCompilationflags the excluded assemblies asHideReferenceFromCompositeand drops them fromReadyToRunCompositeBuildReferences, so crossgen2 receives no-rreferences and CoreCLR rejects the resulting image at startup.This will be validated in dotnet/macios@44b767cf66 (PR dotnet/macios#25583).