Fix HubConnection handshakeRejector force-unwrapped #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove force unwrap from handshakeRejector and handshakeResolver
Contributor
Author
|
@dotnet-policy-service agree company="Zenitech" |
zackliu
approved these changes
Oct 7, 2025
xingsy97
added a commit
that referenced
this pull request
Dec 1, 2025
* Add action for dev (#72) * Add message buffer (#73) * Add message buffer * Some improvement * Improve again * Add client to server stream (#74) * Add client to server stream * increase timeout * Add public initializer to HttpConnectionOptions to allow external instantiation (#76) * hide stateful reconnect, prepare release for 1.0.0-preview.4 (#78) * Hide stateful reconnect options * Add public init for MsgpackTimestamp * Release 1.0.0-preview.4 * Update readme * Support E2E test (#89) * Update README.md (#87) * fix ci/cd failure by updating mac os version (#98) * Address reference cycle between HubConnection and HttpConnection. (#85) * Update HubConnection.swift (#92) Remove force unwrap from handshakeRejector and handshakeResolver Co-authored-by: Chenyang Liu <zackliu1995@hotmail.com> * Typo fix (#94) Co-authored-by: Siyuan <87063252+xingsy97@users.noreply.github.com> Co-authored-by: Chenyang Liu <zackliu1995@hotmail.com> * Make HubConnectionState Sendable (#90) * support stateful reconnect (#96) * Prepare stable 1.0.0 (#103) * update READM.md (#105) * resolve conflict to merge dev into main (#106) --------- Co-authored-by: Chenyang Liu <zackliu1995@hotmail.com> Co-authored-by: bjqian <bjqian100@gmail.com> Co-authored-by: Yannis Alexiou <yannisalexiou@users.noreply.github.com> Co-authored-by: Dan Moseley <danmose@microsoft.com> Co-authored-by: Matt Gallagher <mattgallagher@users.noreply.github.com> Co-authored-by: Andrei Ardelean <41110219+andreiardelean-zenitech@users.noreply.github.com> Co-authored-by: Abi Shrestha <60970080+scifisatan@users.noreply.github.com> Co-authored-by: Guido Hendriks <me@guido.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove force unwrap of handshakeRejector and handshakeResolver from HubConnection.
Fixes: #91