Open
Conversation
… files Teaches agents F# compilation order rules, signature file placement, and common FS0039/FS0010/FS0034 fixes. Includes eval with three scenarios (add module, fix broken order, add signature file) and test fixtures. Validated +64.6% improvement on gpt-4.1 (significant, CI [+17.2%, +63.0%]). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… files Teaches agents F# compilation order rules, signature file placement, and common FS0039/FS0010/FS0034 fixes. Includes eval with three scenarios (add module, fix broken order, add signature file) and test fixtures. Validated +64.6% improvement on gpt-4.1 (significant, CI [+17.2%, +63.0%]). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ro/skills into feature/fsharp-projects-mgmt
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new .NET skill focused on F# .fsproj compilation ordering and signature file (.fsi) placement, along with an eval suite and fixtures to measure improvements.
Changes:
- Added
fsharp-project-structureskill documentation underplugins/dotnet/skills/. - Added eval scenarios + F# project fixtures under
tests/dotnet/fsharp-project-structure/. - Updated
.github/CODEOWNERSto assign ownership for the new skill and test area.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/dotnet/fsharp-project-structure/eval.yaml | Adds 3 eval scenarios covering adding modules, fixing file order, and adding .fsi signature files. |
| tests/dotnet/fsharp-project-structure/OrderService/Domain.fs | Adds an F# domain model fixture for ordering/signature scenarios. |
| tests/dotnet/fsharp-project-structure/OrderService/Services.fs | Adds an F# services fixture referencing Domain. |
| tests/dotnet/fsharp-project-structure/OrderService/Program.fs | Adds an executable entry point fixture used by scenarios. |
| tests/dotnet/fsharp-project-structure/OrderService/OrderService.fsproj | Adds a “correctly ordered” .fsproj fixture. |
| tests/dotnet/fsharp-project-structure/BrokenOrder/Domain.fs | Adds a domain fixture used in the “broken order” scenario. |
| tests/dotnet/fsharp-project-structure/BrokenOrder/Services.fs | Adds a services fixture that will fail if compiled before Domain.fs. |
| tests/dotnet/fsharp-project-structure/BrokenOrder/Program.fs | Adds an entry point fixture for the broken-order project. |
| tests/dotnet/fsharp-project-structure/BrokenOrder/BrokenOrder.fsproj | Adds an intentionally misordered .fsproj fixture to trigger FS0039. |
| plugins/dotnet/skills/fsharp-project-structure/SKILL.md | Adds the new skill guidance for .fsproj ordering and .fsi rules. |
| .github/CODEOWNERS | Assigns code owners for the new skill and its tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
/evaluate |
Contributor
Skill Validation Results
Model: claude-opus-4.6 | Judge: claude-opus-4.6 |
Contributor
|
@T-Gro - can you update this PR to create a new plugin named dotnet-fsharp and add this skill to it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds skill for F# project file structure: compilation order,
.fsisignature files, and commonFS0039/FS0010/FS0034fixes.Eval results (gpt-4.1, 3 runs, judged by claude-opus-4.6):
Overall: +64.6%, significant, CI [+17.2%, +63.0%], overfitting 0.08 (low).