Add CollectionBuilderAttribute to System.Collections.Immutable #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CollectionBuilderAttribute is another attribute that's used to light-up compiler API. This attribute is filtered by GenAPI. Add it back manually to support Collection expressions with immutable collections. dotnet/sdk#33693
ericstj
requested review from
MichaelSimons,
mthalman and
oleksandr-didyk
as code owners
|
I followed a similar pattern to #873. I fixed up the targets so it will also build on Windows (noticed while testing my change locally). |
CyrusNajmabadi
approved these changes
Jan 23, 2024
ViktorHofer
approved these changes
Jan 23, 2024
...erencePackages/src/system.collections.immutable/8.0.0/System.Collections.Immutable.Manual.cs
Show resolved
Hide resolved
ViktorHofer
approved these changes
Jan 23, 2024
MichaelSimons
approved these changes
Jan 23, 2024
mthalman
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CollectionBuilderAttribute is another attribute that's used to light-up compiler API. This attribute is filtered by GenAPI.
Add it back manually to support Collection expressions with immutable collections.
dotnet/sdk#33693