CentOSStream8_Mono_Offline_MsftSdk_x64 leg is failing due to missing ROOTFS_DIR

[NikolaMilosavljevic]

https://dev.azure.com/dnceng/internal/_build/results?buildId=2368375&view=results

Last successful run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2367435&view=results

There are 5 commits in new run, most for dependency flow.

Suspect PR: dotnet/installer#18476

cc @directhex

Error:

      Commencing build of "  iltools " target in "CoreCLR component" for linux.x64.Release in /vmr/src/runtime/artifacts/obj/coreclr/linux.x64.Release
      Invoking "/vmr/src/runtime/eng/native/gen-buildsys.sh" "/vmr/src/runtime/src/coreclr" "/vmr/src/runtime/artifacts/obj/coreclr/linux.x64.Release" x64 linux clang Release ""  -DCLR_CMAKE_PGO_INSTRUMENT=0 -DCLR_CMAKE_OPTDATA_PATH= -DCLR_CMAKE_PGO_OPTIMIZE=0 -DCLI_CMAKE_FALLBACK_OS="centos.8" -DFEATURE_DISTRO_AGNOSTIC_SSL=0  -DCLR_CMAKE_KEEP_NATIVE_SYMBOLS=true
      ROOTFS_DIR not set for crosscompile
##[error]Failed to generate "CoreCLR component" build project!

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[NikolaMilosavljevic]

This also reproes in my private VMR build (https://dev.azure.com/dnceng/internal/_build/results?buildId=2368922&view=results) which includes more changes from installer repo (up to 7a829e58d30ff9b8de6d5c0a8c160059ff40c917)

[ViktorHofer]

@directhex looks like your change caused the regression. PTAL.

[ViktorHofer]

I just noticed this difference in the last passing build and the currently failing one:

+ [[ True == \T\r\u\e ]]
+ customEnvVars='BUILD_SOURCEVERSION=ababfa8c60f99a23f07e5bd03ad2e0cc4a9fddb3 CROSSCOMPILE=1'

In the last passing build, CROSSCOMPILE=1 wasn't passed in as an env var: https://dev.azure.com/dnceng/internal/_build/results?buildId=2367435&view=logs&j=6a27b9b5-d8ec-5163-169b-8b2be859a5ea&t=787e31b3-ac99-5202-0798-f52b20936314

Probably caused by this dotnet/installer@cca2b7b#diff-dc549eeb99aa73960e74c9d4c160a3c76e3e414398bb348c1d5365aac0369ad5L250-R259

[ViktorHofer]

Before the change, targetRid not empty and useMonoRuntime true meant => this is a cross-build. Now, without targetRid, all builds that set useMonoRuntime true are considered cross-builds.

Should a new parameter be added, i.e. isCrossBuild: true or should the logic be conditioned on the already existing crossRootFs parameter?

[directhex]

Hm. Normally I'm a believer in not using conditional A to control behaviour B, but I think in this case conditioning on crossRootFs is correct and adding a new parameter would be needlessly duplicative

[ViktorHofer]

Agreed. I think you would only ever set crossRootFs when cross-building.