Microsoft.DotNet.SourceBuild.Tests.PoisonTests.VerifyUsage failing

[ViktorHofer]

<PrebuiltLeakReport>
  <File Path="artifacts/packages/Release/Shipping/msbuild/Microsoft.Build.Runtime.x.y.z/contentFiles/any/netx.y/ref/mscorlib.dll">
    <Type>AssemblyAttribute</Type>
  </File>
  <File Path="artifacts/packages/Release/Shipping/msbuild/Microsoft.Build.Runtime.x.y.z/contentFiles/any/netx.y/ref/netstandard.dll">
    <Type>AssemblyAttribute</Type>
  </File>
</PrebuiltLeakReport>

These are coming in via https://github.com/dotnet/msbuild/blob/a10ca4529c177605addf622c572a1c563c7a819c/src/MSBuild/MSBuild.csproj#L227-L239. What is surprising is that this code path didn't change recently.

NetStandard.Library/2.0.3 is coming in via SBRP and its assets must not be redistributed. Why is this suddenly showing up and not before?

[MichaelSimons]

@NikolaMilosavljevic - Could you investigate this? In the most recent builds, these are not being reported.

[NikolaMilosavljevic]

Interesting, this was failing for a day in VMR Lite pipeline, and only in CentOSStream9_Offline_PreviousSourceBuiltSdk_x64 leg.

[ViktorHofer]

FWIW it was also failing in the dotnet-source-build (internal) pipeline but passed after a retry

[NikolaMilosavljevic]

FWIW it was also failing in the dotnet-source-build (internal) pipeline but passed after a retry

Yeah, this one is weird, I'll try to see if I can repro locally. Here's the diff between first failing and previous (successful) sha - https://github.com/dotnet/dotnet/compare/f22a2a4..b8272b9 Only emsdk changes.

[ViktorHofer]

Right. What I don't understand is why this hasn't been failing for years. MSBuild redistributes assemblies from the netstandard.library and when building source-only, those come from SBRP which should never get redistributed.

[NikolaMilosavljevic]

My guess is that SBRP package is unintentionally used as a fallback, and in successful builds we actually resolve a real package with the same version. Will investigate pipeline logs more closely.

BTW, my local build did not experience this issue.

[ViktorHofer]

Failed again in https://dev.azure.com/dnceng/internal/_build/results?buildId=2690476&view=logs&j=2efcdee0-63a0-5f4c-6890-20d889251d12&t=f151715a-2289-5b37-2e51-6689ccb5b608&l=230