Skip to content

Conversation

@crummel
Copy link
Contributor

@crummel crummel commented Jan 20, 2022

Fixes #2715.

@ghost ghost added the area-additional-repos Adding additional contributing repos label Jan 20, 2022
@crummel crummel marked this pull request as ready for review January 20, 2022 21:27
@crummel crummel requested a review from a team as a code owner January 20, 2022 21:27
@MichaelSimons
Copy link
Member

I included a guidance doc for adding new repos to source-build.

@crummel crummel requested a review from MichaelSimons April 29, 2022 16:40
@crummel
Copy link
Contributor Author

crummel commented Apr 29, 2022

I believe I've incorporated all the review feedback - please re-review if you would like.

Co-authored-by: Michael Simons <msimons@microsoft.com>
@crummel crummel requested a review from MichaelSimons May 3, 2022 21:13
@crummel crummel requested a review from MichaelSimons May 4, 2022 16:50
Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for creating this documentation. It is going to be helpful for repo devs.

@crummel crummel merged commit b431045 into dotnet:release/6.0 May 4, 2022
crummel added a commit to crummel/dotnet_source-build that referenced this pull request May 24, 2022
* Add guidance for new dependencies

* Instructions for upating dependencies.

* Guidance for new features

* Add general build info guidance.

* Add index.

* Add onboarding new repo documentation

* Address code review comments.

* Markdown linter clean.
MichaelSimons pushed a commit that referenced this pull request May 24, 2022
* Add guidance for new dependencies

* Instructions for upating dependencies.

* Guidance for new features

* Add general build info guidance.

* Add index.

* Add onboarding new repo documentation

* Address code review comments.

* Markdown linter clean.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-additional-repos Adding additional contributing repos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants