Skip to content

Conversation

@lbussell
Copy link
Member

Fixes #2888

@ghost ghost added the area-additional-repos Adding additional contributing repos label Nov 28, 2022
Copy link
Contributor

@crummel crummel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need any kind of header or something to help people pull the JSON out? If it's doable without that it looks good to me.

@dotnet/distro-maintainers

<!--
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @crummel that a better indication of the machine readable section should be considered. Avoiding a comment block would make this more visible and promote usage. e.g. ```json would be better IMO.

Copy link
Member Author

@lbussell lbussell Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, would we rather have the info be visible in the announcement? The original suggestion was explicitly for a comment (see #1836 (comment))

I can put together an example of how to pull the info from the discussion announcement.

@lbussell
Copy link
Member Author

I've updated the info to be visible in the announcement. Here's an example of how you might query the github discussions page to trigger automation from: https://gist.github.com/lbussell/75d1302e06f8115083f420d783e931a8

@lbussell lbussell merged commit f72d315 into dotnet:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-additional-repos Adding additional contributing repos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include machine-readable info in markdown comment in release announcement post

3 participants