Skip to content

[main] Add release info as json to announcement discussion posts #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2022
Merged

[main] Add release info as json to announcement discussion posts #3132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3957d18
Add json comment to announcement markdown
lbussell Nov 28, 2022
56e5924
Make release info visible
lbussell Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion eng/source-build-release-announcement.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,13 @@ Please use the [$TAG tag]($TAG_URL) to source-build .NET version $RUNTIME_VERSIO
- Release Notes: $RELEASE_NOTES_URL
- Tag URL: $TAG_URL

@dotnet/distro-maintainers
@dotnet/distro-maintainers

```json
{
Copy link
Member

@MichaelSimons MichaelSimons Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @crummel that a better indication of the machine readable section should be considered. Avoiding a comment block would make this more visible and promote usage. e.g. ```json would be better IMO.

Copy link
Member Author

@lbussell lbussell Nov 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, would we rather have the info be visible in the announcement? The original suggestion was explicitly for a comment (see #1836 (comment))

I can put together an example of how to pull the info from the discussion announcement.

"Channel": "$RELEASE_CHANNEL",
"Runtime": "$RUNTIME_VERSION",
"Sdk": "$SDK_VERSION",
"InstallerTag": "$TAG"
}
```