-
Notifications
You must be signed in to change notification settings - Fork 138
Update VMR re-bootstrapping guidance #4284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VMR re-bootstrapping guidance #4284
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| 1. Update the arcade SDK version in the [global.json](https://github.com/dotnet/dotnet/blob/main/global.json). | ||
| 1. Update the arcade dependency commit and version in the [Version.Details.xml](https://github.com/dotnet/dotnet/blob/main/eng/Version.Details.xml). | ||
| 1. Update private source-built SDK and artifacts versions | ||
| 1. Update `PrivateSourceBuiltSdkVersion` and `PrivateSourceBuiltArtifactsVersion` in the [Versions.props](https://github.com/dotnet/dotnet/blob/main/eng/Versions.props). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these links of files that need to be updated should really be pointing to the installer repo since that's where the change needs to be made. This applies to other links in this doc as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've followed the existing model, that uses VMR links. @MichaelSimons ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a bad decision on my part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK - fixing this now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with 035e76d
| 1. Find a [dotnet-source-build](https://dev.azure.com/dnceng/internal/_build?definitionId=1219) | ||
| with the desired changes. | ||
| 1. Retrieve the built SDKs from the following legs: | ||
| 1. Retrieve the built SDKs and PSB artifacts archives, from the following legs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PSB should spelled out. To me PSB means previous SB artifacts but in this context you are really retrieving the current artifacts to use as the PSB when building the next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense - will update to private source-built artifacts archive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with 035e76d
This PR adds: