Missing actual source code from https://source.dot.net/

[ManickaP]

https://source.dot.net/ now contains platform agnostic source code, which is in many cases is just empty classes throwing PlatformNotSupportedException, similar to ref sources, making it not very useful for the purpose of browsing the source code.

We noticed in the pipeline that it processes multiple *.notsupported.cs source files, instead of originally using linux versions:
https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/2747243/logs/166 (look for *.notsupported.cs)

Quoting @ericstj:

IMO better deduping logic in the source indexer is the right solution here. We cannot count on only ever having a single "best" build of a project.

Potential culprit: dotnet/runtime#116772

Example https://source.dot.net/#System.Net.NameResolution/artifacts/obj/System.Net.NameResolution/Debug/net10.0/System.Net.NameResolution.notsupported.cs,f8023b9c19212708:

Noticed on 10.7., in recent past it was OK.

[ericstj]

I'd suggest we look at all projects, their frameworks, and some property (EG: PreferSourceIndex).

When considering a project we skip that project if

1. None of the existing exclusions apply.
2. Some other instance of the same project sets PreferSourceIndex=true
3. Some other instance of the same project has a more specific TargetFramework.

Maybe we just group them by name and do this deduping once - to select the best CompilerInvocation for an assembly of that name -

source-indexer/src/SourceBrowser/src/BinLogToSln/Program.cs

Line 79 in 50c6287

foreach (CompilerInvocation invocation in invocations)

[ManickaP]

@ericstj do you know when will the fix be propagated to https://source.dot.net/?

[jjonescz]

In runtime you need to update arcade dependency to include this: dotnet/arcade@12eb994 (maybe that's already done, I haven't checked), then wait for runtime official build which publishes the stage 1 artifacts, then wait for official build of this (source-indexer) repo which finally publishes the site :)

[ericstj]

It flows to dotnet/dotnet then back to all repos. It'll still be a day or so. I made the change to arcade yesterday.

[ericstj]

Reopened this until the fix lands in runtime's build and that's consumed by source-index.

The change was merged to dotnet/dotnet yesterday but there has not been a successful official build due to timeouts https://dev.azure.com/dnceng/internal/_build?definitionId=1330&_a=summary&repositoryFilter=508&branchFilter=244997%2C244997&view=branches.

Once this flows back to runtime we need a runtime official build, then a source-index build in order to get the fix.

[ericstj]

Should be fixed now. https://source.dot.net/#System.Net.NameResolution/System/Net/Dns.cs,f8023b9c19212708

[ManickaP]

It was fixed this morning, but it got somehow reverted during the day:

[ericstj]

Probably multiple branches publishing the index data? Let's open a separate issue