Fix CG alert around Microsoft.IO.Redist #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpar
reviewed
Aug 6, 2024
Co-authored-by: Jared Parsons <jared@paranoidcoding.org>
ericstj
reviewed
Aug 6, 2024
| <PackageVersion Include="Microsoft.Build.Utilities.Core" Version="17.5.0" /> | ||
| <PackageVersion Include="Microsoft.Build" Version="17.5.0" /> | ||
|
|
||
| <!-- component governance --> |
There was a problem hiding this comment.
Not sure it's helpful to say component governance here. We need this because it's a transitive dependency of MSBuild.
There was a problem hiding this comment.
Oh, sorry, had auto-merge set so it merged after your approval but I can fix this in a follow up. The thinking here is that this isn't a direct dependency, so I wanted to add a section for Versions that are only there due to lifting transitive dependencies for CG. We do that in Aspire too. This way, we know we can safely remove those once we update direct dependencies that have bumped the transitive version.
ericstj
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing Component Governance alert due to a transitive dependency.