Skip to content

Add microsoft-spark 3.2 jar #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 93 commits into from
Jan 27, 2022
Merged

Add microsoft-spark 3.2 jar #1010

merged 93 commits into from
Jan 27, 2022

Conversation

@Niharikadutta
Copy link
Collaborator

@Niharikadutta Niharikadutta commented Jan 7, 2022 •
edited
Loading

Add files to support microsoft-spark-3-2 jar

  1. Modified src/scala/pom.xml. Added microsoft-spark-3-2 module
  2. Copied files from src/scala/microsoft-spark-3-1 to src/scala/microsoft-spark-3-2
  3. Modified DotnetRunner.scala
  4. Removed SecurityManager from Utils.fetchFile API call due to signature change [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile apache/spark#30945

@Niharikadutta Niharikadutta reopened this Jan 10, 2022
@Niharikadutta Niharikadutta reopened this Jan 10, 2022
@Niharikadutta Niharikadutta marked this pull request as ready for review January 27, 2022 02:23
@Niharikadutta Niharikadutta changed the title [Test] Add microsoft-spark 3.2 jar Add microsoft-spark 3.2 jar Jan 27, 2022
@suhsteve
Copy link
Member

suhsteve commented Jan 27, 2022 •
edited
Loading

Can you separate this into smaller PRs?

  • microsft-spark.jar
  • 3.2.x contract change and tests

@Niharikadutta
Copy link
Collaborator Author

Niharikadutta commented Jan 27, 2022

Can you separate this into smaller PRs?

  • microsft-spark.jar
  • 3.2.x contract change and tests

@suhsteve converted this PR to have only changes for new microsoft-spark build.

suhsteve
suhsteve reviewed Jan 27, 2022
View reviewed changes
suhsteve
suhsteve approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@suhsteve suhsteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Niharikadutta

imback82
imback82 approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Niharikadutta!

@imback82 imback82 merged commit 7bc016f into dotnet:main Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suhsteve suhsteve suhsteve approved these changes

+1 more reviewer

@imback82 imback82 imback82 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Niharikadutta @suhsteve @imback82