Skip to content

Switch to 1ES hosted pools on main #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2022
Merged

Switch to 1ES hosted pools on main #1021

merged 1 commit into from
Feb 3, 2022

Conversation

@jonfortescue
Copy link
Contributor

@jonfortescue jonfortescue commented Feb 2, 2022

We've officially decommissioned the old BuildPools (see partners mail) in favor of 1ES hosted pools. This change moves dotnet/spark appropriately.

@suhsteve
Copy link
Member

suhsteve commented Feb 2, 2022

@jonfortescue We are also using the Hosted VS2017 pool in our pipeline. Are there any plans to decommission this in the future or is it still fine to use ? If the former, then what should we switch to instead ?

@jonfortescue
Copy link
Contributor Author

jonfortescue commented Feb 2, 2022

@suhsteve nope, no plans to decommission those pools. You're good to use them as long as they're only being used for public builds; for internal builds, the guidance is to only use the 1ES hosted pools.

suhsteve
suhsteve approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@suhsteve suhsteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jonfortescue !

@jonfortescue
Copy link
Contributor Author

jonfortescue commented Feb 2, 2022

@suhsteve awesome! I can't merge bc I'm not a maintainer so if you could merge for me that would be greatly appreciated. :)

@suhsteve suhsteve requested a review from imback82 February 2, 2022 22:56
imback82
imback82 approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jonfortescue!

@imback82 imback82 merged commit fac8def into dotnet:main Feb 3, 2022
@jonfortescue jonfortescue deleted the SwitchTo1esPools branch February 15, 2022 00:13
@suhsteve suhsteve mentioned this pull request Apr 25, 2022
Closed
Niharikadutta pushed a commit to Niharikadutta/spark that referenced this pull request Apr 25, 2022
@jonfortescue @Niharikadutta
Switch to 1ES hosted pools on main (dotnet#1021)
3fc8b32
@Niharikadutta Niharikadutta mentioned this pull request Apr 25, 2022
Merged
Niharikadutta added a commit that referenced this pull request Apr 25, 2022
@Niharikadutta @jonfortescue
Switch to 1ES hosted pools on release/branch-1.0 (#1021)(#1030) (#1056)
9c90c82 
* Switch to 1ES hosted pools on main (#1021)

* Switch queue to demands to fix error (#1030)

Co-authored-by: Jon Fortescue <jofortes@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suhsteve suhsteve suhsteve approved these changes

+1 more reviewer

@imback82 imback82 imback82 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonfortescue @suhsteve @imback82