Skip to content

Conversation

@MattGal
Copy link
Member

@MattGal MattGal commented Nov 1, 2022

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 1115 in repo dotnet/spark

@MattGal MattGal changed the title Try renaming service connection from dotnet -> public Rename service connection from dotnet -> public and update public pool name Nov 1, 2022
@MattGal MattGal marked this pull request as ready for review November 1, 2022 20:19
Copy link
Contributor

@AFFogarty AFFogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MattGal!

@AFFogarty AFFogarty requested a review from suhsteve November 1, 2022 21:17
@suhsteve suhsteve changed the title Rename service connection from dotnet -> public and update public pool name Fix build pipeline: Rename service connection from dotnet -> public and update public pool name Nov 1, 2022
@suhsteve suhsteve added the infrastructure Build pipeline, etc. label Nov 1, 2022
Copy link
Member

@suhsteve suhsteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@suhsteve suhsteve merged commit 3244c18 into dotnet:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Build pipeline, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants