Skip to content

Add multiple stages for Azure Pipeline#524

Merged
imback82 merged 42 commits into
dotnet:masterfrom
elvaliuliuliu:elva/multi_stages
Jun 13, 2020
Merged

Add multiple stages for Azure Pipeline#524
imback82 merged 42 commits into
dotnet:masterfrom
elvaliuliuliu:elva/multi_stages

Conversation

@elvaliuliuliu
Copy link
Copy Markdown
Contributor

@elvaliuliuliu elvaliuliuliu commented May 18, 2020 •
edited
Loading

This PR adds multiple stages for Azure Pipeline which will fix #509 , the Azure Pipeline will have the following stages:

  • Build Sources: Build current sources
    (Once the build is finished successfully, the following three testing stages will start)
  • E2E Tests: Run current E2E tests
  • E2E Forward Compatibility Tests: Run E2E tests in the lastest compatible release with current worker
  • E2E Backward Compatibility Tests: Run current E2E tests with the lastest compatible worker

@elvaliuliuliu elvaliuliuliu changed the title [WIP] Multiple stages for the Azure Pipeline Add multiple stages for Azure Pipeline May 19, 2020
@imback82
Copy link
Copy Markdown
Contributor

imback82 commented May 21, 2020

Can we not rebuild in the subsequent stages? We should just build once in the first stage and reuse the binaries in the testing stages.

@elvaliuliuliu elvaliuliuliu changed the title Add multiple stages for Azure Pipeline [WIP] Add multiple stages for Azure Pipeline May 22, 2020
@elvaliuliuliu elvaliuliuliu changed the title [WIP] Add multiple stages for Azure Pipeline Add multiple stages for Azure Pipeline Jun 2, 2020
@imback82 imback82 added the enhancement New feature or request label Jun 4, 2020
@imback82
Copy link
Copy Markdown
Contributor

imback82 commented Jun 4, 2020

Is this ready for review?

@elvaliuliuliu
Copy link
Copy Markdown
Contributor Author

elvaliuliuliu commented Jun 4, 2020

Is this ready for review?

Yea, this is ready for review. Thanks!

@imback82 imback82 mentioned this pull request Jun 12, 2020
Merged
imback82
imback82 reviewed Jun 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few minor comments but the general approach looks good to me. @Niharikadutta also verified the generated artifacts from the internal build pipeline.

Comment thread azure-pipelines.yml
backwardCompatibleRelease: '0.9.0'
# forwardCompatibleRelease/backwardCompatibleRelease is the "oldest" releases that work with the current release
forwardCompatibleRelease: '0.9.0'
backwardCompatibleRelease: '0.9.0'
Copy link
Copy Markdown
Contributor

@imback82 imback82 Jun 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason the order got flipped?

Copy link
Copy Markdown
Contributor Author

@elvaliuliuliu elvaliuliuliu Jun 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just thought the order of E2E FC Tests, E2E BC Tests more readable. So flip the order here to be consistent. But I can convert it back. Please let me know what is preferred.

Copy link
Copy Markdown
Contributor

@imback82 imback82 Jun 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, not sure why it's more readable, but it's fine.

Comment thread azure-pipelines.yml Outdated
Comment thread azure-pipelines.yml Outdated
Comment thread azure-pipelines.yml Outdated
@imback82
Copy link
Copy Markdown
Contributor

imback82 commented Jun 13, 2020

Btw, the azure-pipeline.xml is getting too long to maintain. Can you update this with templates, https://docs.microsoft.com/en-us/azure/devops/pipelines/process/templates?view=azure-devops? E2E tests are good candidates. You can do this as a follow-up PR.

@elvaliuliuliu
Copy link
Copy Markdown
Contributor Author

elvaliuliuliu commented Jun 13, 2020 •
edited
Loading

Btw, the azure-pipeline.xml is getting too long to maintain. Can you update this with templates, https://docs.microsoft.com/en-us/azure/devops/pipelines/process/templates?view=azure-devops? E2E tests are good candidates. You can do this as a follow-up PR.

Sounds good, E2E tests could be templates. Will do as a follow-up PR.

imback82
imback82 approved these changes Jun 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @elvaliuliuliu!

@imback82 imback82 merged commit e43a0a4 into dotnet:master Jun 13, 2020
@elvaliuliuliu elvaliuliuliu deleted the elva/multi_stages branch June 13, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@imback82 imback82 imback82 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@elvaliuliuliu elvaliuliuliu

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST]: Multiple stages for the Azure Pipeline

2 participants

@elvaliuliuliu @imback82