Add Param and methods to Spark.ML #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 8, 2020 19:29
imback82
reviewed
Jul 8, 2020
GoEddie
changed the title
GoEddie
changed the title
|
@suhsteve / @Niharikadutta Can you help with review? |
imback82
reviewed
Jul 17, 2020
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/BucketizerTests.cs
Show resolved
Hide resolved
suhsteve
previously approved these changes
Jul 17, 2020
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Param/ParamTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Steve Suh <suhsteve@gmail.com>
GoEddie
changed the title
suhsteve
reviewed
Jul 21, 2020
GoEddie
changed the title
imback82
reviewed
Jul 22, 2020
imback82
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Param class and the appropriate methods on FeatureBase to be shared by all the Features that implement
https://spark.apache.org/docs/1.5.1/api/java/org/apache/spark/ml/param/Params.html.The scala class is
org.apache.spark.ml.param.Parambut the .NET naming standard isSpark.ML.Param.Paramso defining it in C# means usingParam.Param- not sure if that is acceptable or if it is worth moving it up a level in the namespace?