Support for Delta Lake 0.8.0 #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhsteve
previously approved these changes
Feb 11, 2021
imback82
reviewed
Feb 12, 2021
Contributor
imback82
left a comment
imback82
left a comment
There was a problem hiding this comment.
LGTM (minor comments), thanks @AFFogarty!
|
|
||
| Assert.IsType<DeltaTable>(DeltaTable.ForName(tableName)); | ||
| Assert.IsType<DeltaTable>(DeltaTable.ForName(_spark, tableName)); | ||
| DeltaTable table = Assert.IsType<DeltaTable>(DeltaTable.ForName(_spark, tableName)); |
Contributor
There was a problem hiding this comment.
Assert.IsType<DeltaTable> not required if you are setting it to DeltaTable table.
Comment on lines
30
to
31
| ("spark.databricks.delta.minReaderVersion", "1"), | ||
| ("spark.databricks.delta.minWriterVersion", "2") |
Contributor
There was a problem hiding this comment.
Is this required for upgradeTableProtocol? If so, could you add a comment?
imback82
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR adds support for Delta Lake 0.8.0. This includes a new API
DeltaTable.UpgradeTableProtocol().