Skip to content
This repository was archived by the owner on Sep 13, 2022. It is now read-only.

Add support for typed-datasets#1446

Merged
terrajobst merged 1 commit intodotnet:masterfrom
terrajobst:datatable-designer
Aug 21, 2019
Merged

Add support for typed-datasets#1446
terrajobst merged 1 commit intodotnet:masterfrom
terrajobst:datatable-designer

Conversation

@terrajobst
Copy link
Copy Markdown

This completes the support for typed datasets which also enables the dataset designer in VS.

See dotnet/corefx#36528.

@terrajobst terrajobst requested review from divega and roji August 20, 2019 00:01
@terrajobst terrajobst requested review from a team as code owners August 20, 2019 00:01
@terrajobst terrajobst added the netstandard-api This tracks requests for standardizing APIs. label Aug 20, 2019
Copy link
Copy Markdown

@divega divega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@terrajobst
Copy link
Copy Markdown
Author

terrajobst commented Aug 20, 2019

@agocke @jaredpar @stephentoub @marek-safar Any concerns? I'd like to take this change to ship room.

@terrajobst
Copy link
Copy Markdown
Author

Adding @akoeplinger as Marek is on vacation

@terrajobst terrajobst merged commit 4498e6a into dotnet:master Aug 21, 2019
@terrajobst terrajobst deleted the datatable-designer branch August 21, 2019 17:18
@ericstj
Copy link
Copy Markdown
Member

ericstj commented Oct 22, 2019

This should have also added System.Data.DataSetExtensions.dll to netstandard2.1. See https://github.com/dotnet/corefx/issues/41966

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

netstandard-api This tracks requests for standardizing APIs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants