Migrates the extension to latest VS Code and TypeScript #1058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the extension and several dependencies to the latest VS Code and TypeScript per the instructions at https://code.visualstudio.com/upgrades/v1_6#_extension-authoring.
This change runs unit tests inside of VS Code, making it possible to set breakpoints and debug test, and to let tests access VS Code services. In addition, the syntax tests are split out into a separate "npm run test-syntax" script that runs using Mocha at the command-line. The reason for this is because the onigurama package used by those tests is native-compiled, and the compiled binary does not necessarily like running in VS Code 32-bit on Windows. Ultimately, the syntax tests will be moving into their own repo, so this is just a temporary measure.
DustinCampbell
force-pushed
the
upgrade-extension
branch
from
f92f29e to
b9026a6
Compare
Member
Author
|
@gregg-miskelly, adding you to this as well. This allows me to write proper tests for 'tasks.json' and 'launch.json' generation as I work on it. |
gregg-miskelly
approved these changes
Dec 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the extension and several dependencies to the latest VS Code and TypeScript per the instructions at https://code.visualstudio.com/upgrades/v1_6#_extension-authoring. This lets us get rid of many of our typings files and pull them in with dev-dependencies.
Note: This may require a more recent version of Node on your machine since we're allowing TypeScript to target es6 now.