Simplifying remoteProcessPicker #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To LaunchBrowserPlatformOptions.
The launch.json configuration is passed in via the args parameter. There is no need to read the launch.json file and find the correct configuration. The old method would only grab the first launch json name that matched. This change allows duplicate launch names but still grabs the correct pipeTransport.
gregg-miskelly
approved these changes
Jan 14, 2017
rajkumar42
approved these changes
Jan 18, 2017
Contributor
|
@WardenGnaw should we merge this? |
Contributor
Author
|
This should be good to go. Unless we want to add in the fix for #1130. |
Contributor
|
@WardenGnaw lets just do that as a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1122