Skip to content

Conversation

@DustinCampbell
Copy link
Member

This uses the new tasks.json support in VS Code 1.9 to allow tasks to run different commands. So, now you should be able to build with Cmd+Shift+B in VS Code.

This uses the new tasks.json support in VS Code 1.9 to allow tasks to run different commands. So, now you should be able to build with <kbd>Cmd+Shift+B</kbd> in VS Code.
Copy link
Contributor

@gregg-miskelly gregg-miskelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise sounds good to me.

{
"taskName": "test",
"showOutput": "always",
"isTestCommand": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the 'test' command still correct? I would have thought it would need a command element now that it is gone from the root.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does. I'll take a look.

…elete gulp task for running tests

Since we use VS Code's infrastructure for running tests (allowing us to access VS Code objects inside tests), the right way to run tests inside VS Code is to launch the debugger with the 'Launch Tests' configuration. At the command-line, the 'npm test' command runs tests. However, that downloads a build of VS Code to run the tests, which doesn't support being launched while other instances of VS Code or open.
@DustinCampbell
Copy link
Member Author

@gregg-miskelly: Because we use VS Code's infrastructure to run tests (allowing us to access VS Code objects inside tests), the right way to run tests is to launch the debugger with the 'Launch Tests' configuration. I'd like to be able to launch the VS Code debug command from the test task with that configuration, but there doesn't appear to be a way to do that. So, I'm echoing a message to explain how to run tests instead. Does that work for you?

Copy link
Contributor

@gregg-miskelly gregg-miskelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

"command": "echo",
"showOutput": "always",
"isShellCommand": true,
"args": ["Run tests in VS Code by launching the debugg with the 'Launch Tests' configuration."],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the 'er' in 'debugger'.

@gregg-miskelly
Copy link
Contributor

@DustinCampbell sounds reasonable to me

@DustinCampbell
Copy link
Member Author

cool -- thanks!

@DustinCampbell DustinCampbell merged commit 9c10778 into dotnet:master Feb 6, 2017
@DustinCampbell DustinCampbell deleted the update-build-task branch February 8, 2017 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants