-
Notifications
You must be signed in to change notification settings - Fork 727
Update build task to launch "npm run compile" #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build task to launch "npm run compile" #1186
Conversation
This uses the new tasks.json support in VS Code 1.9 to allow tasks to run different commands. So, now you should be able to build with <kbd>Cmd+Shift+B</kbd> in VS Code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise sounds good to me.
| { | ||
| "taskName": "test", | ||
| "showOutput": "always", | ||
| "isTestCommand": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the 'test' command still correct? I would have thought it would need a command element now that it is gone from the root.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does. I'll take a look.
…elete gulp task for running tests Since we use VS Code's infrastructure for running tests (allowing us to access VS Code objects inside tests), the right way to run tests inside VS Code is to launch the debugger with the 'Launch Tests' configuration. At the command-line, the 'npm test' command runs tests. However, that downloads a build of VS Code to run the tests, which doesn't support being launched while other instances of VS Code or open.
|
@gregg-miskelly: Because we use VS Code's infrastructure to run tests (allowing us to access VS Code objects inside tests), the right way to run tests is to launch the debugger with the 'Launch Tests' configuration. I'd like to be able to launch the VS Code debug command from the test task with that configuration, but there doesn't appear to be a way to do that. So, I'm echoing a message to explain how to run tests instead. Does that work for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
| "command": "echo", | ||
| "showOutput": "always", | ||
| "isShellCommand": true, | ||
| "args": ["Run tests in VS Code by launching the debugg with the 'Launch Tests' configuration."], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing the 'er' in 'debugger'.
|
@DustinCampbell sounds reasonable to me |
|
cool -- thanks! |
This uses the new tasks.json support in VS Code 1.9 to allow tasks to run different commands. So, now you should be able to build with Cmd+Shift+B in VS Code.