Don't show message about projects having trouble loading when there are only warnings #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re only warnings C# for VS Code is a little over-excited about showing the message that there were problems loading projects. Essentially, it will show it if there were warnings or errors. This changes that behavior to only show it if there are errors because it's perfectly reasonable for a project to contain warnings and not complain to the user every time they open it.
gregg-miskelly
approved these changes
Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #707
C# for VS Code is a little over-excited about showing the message that there were problems loading projects. Essentially, it will show it if there were warnings or errors. This changes that behavior to only show it if there are errors because it's perfectly reasonable for a project to contain warnings and not complain to the user every time they open it.