Add launch.json automagically #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinCampbell
force-pushed
the
add-launch-json-automagically
branch
from
83a12b4 to
19309dc
Compare
Contributor
|
👍 |
This change refactors that code that adds or updates the user's tasks.json file to include a build task, to also add a launch.json file if it is missing.
DustinCampbell
force-pushed
the
add-launch-json-automagically
branch
from
19309dc to
1c2b569
Compare
Member
Author
|
Fixed conflicts and rebased |
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the current design:
When the OmniSharp server starts up and there is project.json file in VS Code's workspace root directory, we check to see if there is a tasks.json and launch.json and prompt the user to add them if they're missing. For launch.json, OmniSharp is queried to find the .NET Core project with emitEntryPoint set to true to use for the correct paths.
This works really well for simple .NET Core apps with just a single project.json. Further work is needed to properly handle multi-project apps.
Note: This requires a change on the OmniSharp side to function properly. A PR is out for that change here: OmniSharp/omnisharp-roslyn#462.
cc @gregg-miskelly, @chuckries, @Pilchie