Add telemetry for OmniSharp server requests #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinCampbell
force-pushed
the
server-telemetry
branch
from
ef3825c to
3f033aa
Compare
Contributor
|
Sorry, that comment was supposed to be for the other PR. I haven't had a chance to look at this one yet. Give me a few minutes... |
| "windows": { | ||
| "program": "./coreclr-debug/debugAdapters/OpenDebugAD7.exe" | ||
| }, | ||
| "aiKey": "AIF-d9b70cd4-b9f9-4d70-929b-a071c400b217", |
Contributor
There was a problem hiding this comment.
We need this. VS Code reads this value.
Member
Author
There was a problem hiding this comment.
It does? The instructions for VS Code telemetry do not say to add this to the debuggers section. Or, is this used for the debug adapter telemetry (which I'm totally unfamiliar with).
Contributor
There was a problem hiding this comment.
Yes, it is used with debug adapter telemetry.
Member
Author
There was a problem hiding this comment.
OK -- will add that back. Sorry about that! I wasn't sure because the debugger code just dug it out of package.json.
Contributor
|
👍 |
1. Add aiKey back into package.json for debug-adapter telemetry. In addition, to avoid duplicating the aiKey, the code that constructs a TelemetryReporter once again pulls the key from the package.json. 2. A couple of renames for clarity.
Member
Author
|
@gregg-miskelly I implemented your feedback. Look better now? |
Contributor
|
👍 |
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds telemetry tracking for the time elapsed from the point that a request sent to the OmniSharp server to the point that a response is received. To keep telemetry traffic low, we simply track the counts of various ranges of delay times for each type of request.
In addition, I refactored the telemetry a bit in coreclr-debug.ts to ensure that we can share the same TelemetryReporter.
cc @gregg-miskelly, @chuckries, @Pilchie