Add 'console' to launch.json schema #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checkin completes the external (and integrated) console work by updating the launch.json schema to add the new attributes. I also updated the documentation and templates.
|
@caslan please review |
caslan
reviewed
Mar 3, 2017
debugger.md
Outdated
| #####External console (terminal) window | ||
| The target process can optionally launch into a separate console window. You will want this if your console app takes console input (ex: Console.ReadLine). This can be enabled with: | ||
| #####Console (terminal) window | ||
| By default, processes are launched with their console output (stdout/stderr) going to the VS Code Debugger Console. This is useful for executables that take their input file files, the network, etc. But this does NOT work for applications that want to read from the console (ex: `Console.ReadLine`). For these applications, use a setting such as the following: |
caslan
reviewed
Mar 3, 2017
debugger.md
Outdated
| "externalConsole": true | ||
| "console": "integratedTerminal" | ||
|
|
||
| When this is set to `integratedTerminal` the target process will run inside [VS Code's integrated terminal](https://code.visualstudio.com/docs/editor/integrated-terminal). Click the 'Terminal' tab in the tab group beneith the editor to interact with your application. |
caslan
reviewed
Mar 3, 2017
debugger.md
Outdated
|
|
||
| When this is set to `integratedTerminal` the target process will run inside [VS Code's integrated terminal](https://code.visualstudio.com/docs/editor/integrated-terminal). Click the 'Terminal' tab in the tab group beneith the editor to interact with your application. | ||
|
|
||
| When this is set to `externalTerminal` the target process will run in a seperate terminal. |
caslan
reviewed
Mar 3, 2017
| "cwd": "${workspaceRoot}", | ||
| "stopAtEntry": false, | ||
| "externalConsole": false | ||
| "console": "internalConsole" |
There was a problem hiding this comment.
I can go either way on this, but we might want to have 'integratedTerminal' as the default. The rationale being in the "console" launch configuration you are more likely interacting with an app that takes input. We can wait for community feedback on this too.
There was a problem hiding this comment.
I discussed this with Charlie offline. The problem is that the terminal will get hidden by the debug console by default, so it may not be very obvious where to go and interact with the application. So we will leave it this way for now.
caslan
approved these changes
Mar 3, 2017
|
@gregg-miskelly Looks good, a few typos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checkin completes the external (and integrated) console work by updating the launch.json schema to add the new attributes. I also updated the documentation and templates.