Clean up and adding required fields. #1284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requiring pipeProgram and debuggerPath to PipeTransport. Removing trace and trace response as they have been merged into engine logging.
package.json
Outdated
| "description": "When present, this tells the debugger to connect to a remote computer using another executable as a pipe that will relay standard input/output between VS Code and the .NET Core debugger backend executable (clrdbg).", | ||
| "type": "object", | ||
| "required": [ | ||
| "pipeProgram", |
There was a problem hiding this comment.
"pipeProgram", [](start = 18, length = 14)
We might want to leave pipeProgram optional since it is possible to specify it for each OS rather than using a common one on all OSs
src/tools/OptionsSchema.json
Outdated
| }, | ||
| "PipeTransport": { | ||
| "type": "object", | ||
| "required": ["pipeProgram", "debuggerPath"], |
There was a problem hiding this comment.
pipeProgram [](start = 26, length = 11)
I guess my comment really belongs here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring pipeProgram and debuggerPath to PipeTransport.
Removing trace and trace response as they have been merged into engine
logging.
This replaces: #1171 #1207
@gregg-miskelly