Adding QuoteArgs Flag #1322
Merged
Adding QuoteArgs Flag #1322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregg-miskelly
approved these changes
Mar 14, 2017
package.json
Outdated
| }, | ||
| "quoteArgs": { | ||
| "type": "boolean", | ||
| "description": "Flag to enable or disable quotes around 'debuggerPath'", |
Contributor
There was a problem hiding this comment.
How about this for the description:
Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.
src/tools/OptionsSchema.json
Outdated
| }, | ||
| "quoteArgs": { | ||
| "type": "boolean", | ||
| "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", |
Contributor
There was a problem hiding this comment.
set [](start = 152, length = 3)
I think you want 'to false' here.
gregg-miskelly
approved these changes
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #1318
@gregg-miskelly