Fixing processPicker for WSL #1405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
child_process.exec will spawn a 32 bit process which C:\Windows\System32\bash.exe will not exist and fail for process picker. Will attempt to try to run C:\Windows\sysnative\bash.exe for process picker. This is not an issue if users just use bash.exe for pipeProgram.
gregg-miskelly
approved these changes
Apr 18, 2017
rajkumar42
reviewed
Apr 19, 2017
src/features/processPicker.ts
Outdated
| public static ValidateAndFixPipeProgram(program: string): Promise<string> { | ||
| return PlatformInformation.GetCurrent().then(platformInfo => { | ||
| // If its 64 bit windows and the program does not exist. Try to replace System32 with sysnative | ||
| if (platformInfo.isWindows && platformInfo.architecture === "x86_64" && !fs.existsSync(program) && program.toLowerCase().includes("system32")) { |
Contributor
There was a problem hiding this comment.
It would be nice if we don't enter the if block if the following condition is not satisfied program.toLowerCase().startsWith(process.env.SystemRoot + "system32").
rajkumar42
reviewed
Apr 19, 2017
| } | ||
|
|
||
| // Return original program and let it fall through | ||
| return program; |
Contributor
There was a problem hiding this comment.
It is possible the program does not exist in the sysnative path as well. Should we try and return the original program path if file wasn't found in sysnative path as well?
rajkumar42
approved these changes
Apr 19, 2017
Validating sysnative program before replacing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing error message for process picker.
Find and replace System32 for WSL bash because it spawns a 32 bit instance which bash.exe does not reside in System32 but rather sysnative.