Allow suppression of hidden messages to be configurable with a default to supress #1435
Conversation
|
@cruz82, It will cover your contributions to all .NET Foundation-managed open source projects. |
|
@cruz82, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
DustinCampbell
left a comment
DustinCampbell
left a comment
There was a problem hiding this comment.
Code changes look good! Could you make the requestd tweaks to the user-facing option? Otherwise, it's in good shape.
package.json
Outdated
| "csharp.suppressHiddenMessages": { | ||
| "type": "boolean", | ||
| "default": true, | ||
| "description": "Suppress hidden messages from being shown." |
There was a problem hiding this comment.
How about we go with "hidden diagnostics" rather than "hidden messages".
- setting name:
csharp.suppressHiddenDiagnostics - description:
Suppress 'hidden' diagnostics (such as 'unnecessary using directives') from appearing in the editor or the Problems pane
DustinCampbell
changed the title
|
@DustinCampbell, updated the setting name and the description. |
DustinCampbell
left a comment
DustinCampbell
left a comment
There was a problem hiding this comment.
Looks great -- thanks!
|
I'm planning to release a new C# for VS Code beta later today or early tomorrow. That will have this setting in it. |
|
@cruz82 You're awesome, man! |
5 participants
…t to supress (#1429)