Add telemetry reporting the number of times tests are run or debugged #1692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r a given test framework
gregg-miskelly
approved these changes
Aug 9, 2017
| 'dotnet.test.debug', | ||
| (testMethod, fileName, testFrameworkName) => this._debugDotnetTest(testMethod, fileName, testFrameworkName)); | ||
|
|
||
| this._telemetryIntervalId = setInterval(() => |
Contributor
There was a problem hiding this comment.
I wonder if we should defer this until we first run a test so we don't have something polling for no reason?
Member
Author
There was a problem hiding this comment.
Potentially, though I don't think it's huge deal.
I think what I really want to do here is have a shared component that sends telemetry like this. This is really similar to the telemetry reporting in the OmniSharpServer class, and I'd like to unify them. Are you OK if I leave this for now and unify later? I've filed #1693 to track unifying these in either case.
Member
Author
There was a problem hiding this comment.
Going to go ahead and merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1594
This change looks large, but it's mostly mechanical refactoring to thread the TelemetryReporter through various OmniSharp features. In addition, I took the opportunity to introduce a
TestManagerclass that simply encapsulates all of the functionality in dotnetTest.