Merge master into release #1844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move unit tests into their own folder. Prepare scripts for unit + integration tests.
Integration Test Infrastructure
The integration test: - deletes the .vscode directory - deletes existing build artifacts - issues the `dotnet.generateAssets` command - executes the `.NET Core Launch (console)` debug configuration - validates that a debugSession becomes active - waits for debugging to stop To enable this, and other integration tests, I exposed an export on the csharp extension which can be awaited until the extension is initialized. Initialized is defined as omnisharp and the debugger being ready for invocation. Without awaiting this promise, commands issues to the extension have unpredictable behaviors since they are registered but not yet able to be handled.
I believe this is downloading the extension's dependencies.
…tegrationTests Add Debug Launch integration test
Asset generation now uses the workspace information from OmniSharp to determine which workspace folder to use in the face of a multi-root workspace.
Fix asset generation for multi-root workspaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges over the latest from master, which fixes the asset generation for multi-root workspaces and includes some test-only changes from @TheRealPiotrP.