Enable Integration Tests to expose Logger output #1853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealPiotrP
force-pushed
the
dev/piotrp/logOutput
branch
from
2978fe9 to
69e4553
Compare
Member
|
CI failed with the same weird array of nulls we saw in my PR. Maybe that was unrelated to issue I needed to fix? I'm wondering if the problem is related to the fact that VS Code 1.18 just shipped, so the stable build used for test was updated. |
DustinCampbell
approved these changes
Nov 10, 2017
Member
DustinCampbell
left a comment
DustinCampbell
left a comment
There was a problem hiding this comment.
Nice change. Just need to get that pesky CI fixed.
| * Copyright (c) Microsoft Corporation. All rights reserved. | ||
| * Licensed under the MIT License. See License.txt in the project root for license information. | ||
| *--------------------------------------------------------------------------------------------*/ | ||
| let Subscriber: (message: string) => void; |
Member
There was a problem hiding this comment.
minor, minor nit: blank line before
TheRealPiotrP
force-pushed
the
dev/piotrp/logOutput
branch
3 times, most recently
from
31b0fa5 to
1c83be3
Compare
Author
|
@DustinCampbell @rchande @akshita31 this change ended up being super noisy in the logs. However, I was able to make the UX quite nice anyways :) The latest revision of this change:
Check it out! |
TheRealPiotrP
force-pushed
the
dev/piotrp/logOutput
branch
from
1c83be3 to
0426347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables subscribing a logging callback that will be invoked by all instances of Logger.