Skip to content

Update to omnisharp 1.29 #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 2, 2018
Merged

Update to omnisharp 1.29 #1995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5625722
Update to omnisharp 1.29
Feb 1, 2018
29c2990
Fix links
Feb 1, 2018
2af617b
Make hover test pass
akshita31 Feb 1, 2018
b925279
Merge branch 'master' into omnisharp1.29
Feb 2, 2018
1065ccd
Make hover test pass
akshita31 Feb 1, 2018
6ef8152
Merge branch 'omnisharp1.29' of https://github.com/rchande/omnisharp-…
Feb 2, 2018
d8189f0
Make test pass
Feb 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@
"runtimeDependencies": [
{
"description": "OmniSharp for Windows (.NET 4.6 / x86)",
"url": "https://download.visualstudio.microsoft.com/download/pr/100505823/5804b7d3b5eeb7e4ae812a7cff03bd52/omnisharp-win-x86-1.28.0.zip",
"fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-win-x86-1.28.0.zip",
"url": "https://download.visualstudio.microsoft.com/download/pr/11539709/dcb3a815e48ea792fc788fc9fa6ea379/omnisharp-win-x86-1.29.0.zip",
"fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-win-x86-1.29.0.zip",
"installPath": ".omnisharp",
"platforms": [
"win32"
Expand All @@ -97,8 +97,8 @@
},
{
"description": "OmniSharp for Windows (.NET 4.6 / x64)",
"url": "https://download.visualstudio.microsoft.com/download/pr/100505821/c570a9e20dbf7172f79850babd058872/omnisharp-win-x64-1.28.0.zip",
"fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-win-x64-1.28.0.zip",
"url": "https://download.visualstudio.microsoft.com/download/pr/11539712/2ceb65cab39ffc725480ede21ad8071c/omnisharp-win-x64-1.29.0.zip",
"fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-win-x64-1.29.0.zip",
"installPath": ".omnisharp",
"platforms": [
"win32"
Expand All @@ -110,8 +110,8 @@
},
{
"description": "OmniSharp for OSX",
"url": "https://download.visualstudio.microsoft.com/download/pr/100505818/6b99c6a86da3221919158ca0f36a3e45/omnisharp-osx-1.28.0.zip",
"fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-osx-1.28.0.zip",
"url": "https://download.visualstudio.microsoft.com/download/pr/11539710/5594f85f23035c42f0893f61a19f2340/omnisharp-osx-1.29.0.zip",
"fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-osx-1.29.0.zip",
"installPath": ".omnisharp",
"platforms": [
"darwin"
Expand All @@ -124,8 +124,8 @@
},
{
"description": "OmniSharp for Linux (x86)",
"url": "https://download.visualstudio.microsoft.com/download/pr/100505817/b710ec9c2bedc0cfdb57da82da166c47/omnisharp-linux-x86-1.28.0.zip",
"fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-linux-x86-1.28.0.zip",
"url": "https://download.visualstudio.microsoft.com/download/pr/11539707/ffe833a2a771adead00c977fe9b0a8ea/omnisharp-linux-x86-1.29.0.zip",
"fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-linux-x86-1.29.0.zip",
"installPath": ".omnisharp",
"platforms": [
"linux"
Expand All @@ -142,8 +142,8 @@
},
{
"description": "OmniSharp for Linux (x64)",
"url": "https://download.visualstudio.microsoft.com/download/pr/100505485/3f8a10409240decebb8a3189429f3fdf/omnisharp-linux-x64-1.28.0.zip",
"fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-linux-x64-1.28.0.zip",
"url": "https://download.visualstudio.microsoft.com/download/pr/11539705/289061d8686d4689d66fd1610b6891e2/omnisharp-linux-x64-1.29.0.zip",
"fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-linux-x64-1.29.0.zip",
"installPath": ".omnisharp",
"platforms": [
"linux"
Expand Down
9 changes: 6 additions & 3 deletions test/integrationTests/codeActionRename.integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,12 @@ suite(`Code Action Rename ${testAssetWorkspace.description}`, function() {
test("Code actions can remame and open files", async () => {
let fileUri = await testAssetWorkspace.projects[0].addFileWithContents("test.cs", "class C {}");
await vscode.commands.executeCommand("vscode.open", fileUri);
let c = await vscode.commands.executeCommand("vscode.executeCodeActionProvider", fileUri, new vscode.Range(0, 7, 0, 7)) as {command: string, arguments: string[]}[];
expect(c.length).to.equal(2);
await vscode.commands.executeCommand(c[1].command, ...c[1].arguments)
let c = await vscode.commands.executeCommand("vscode.executeCodeActionProvider", fileUri, new vscode.Range(0, 7, 0, 7)) as {command: string, title: string, arguments: string[]}[];
let command = c.find(
(s) => { return s.title == "Rename file to C.cs" }
)
expect(command, "Didn't find rename class command");
await vscode.commands.executeCommand(command.command, ...command.arguments)
expect(vscode.window.activeTextEditor.document.fileName).contains("C.cs");
});
});
9 changes: 4 additions & 5 deletions test/integrationTests/hoverProvider.integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,11 @@ Parameters:
\t\tgameObject: The game object.
\t\ttagName: Name of the tag.

Returns trueif object is tagged with tag.`;
Returns true if object is tagged with tag.`;
expect(c[0].contents[0].value).to.equal(answer);
});

teardown(async() =>
{
await testAssetWorkspace.cleanupWorkspace();
})
teardown(async () => {
await testAssetWorkspace.cleanupWorkspace();
});
});