-
Notifications
You must be signed in to change notification settings - Fork 728
Initial manual validation plan #2016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| * Standalone csproj | ||
| * Directory containing .sln file that references csprojs--projects should be loaded | ||
| * .NET Core/.NET Standard csproj | ||
| * (Windows) Desktop .NET projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We always get a bunch of feedback on Unity projects. Should we add something there too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I've typically validated Unity projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure--do you have any examples of unity projects people edit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sent some pointers in email.
DustinCampbell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Should there be scenario for running/debugging unit tests?
|
@DustinCampbell Done--I made the section about unit tests more obvious. |
TheRealPiotrP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but we should have a strategy for how the various project types are obtained. I worry we'll waste a bunch of time building up the pre-conditions...
| If you look in "Output > Omnisharp Log" a bunch of information should be printed about what copy of MSBuild was used and what projects were load | ||
|
|
||
| Project types to test: | ||
| * Standalone csproj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do we expect these projects to come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a workitem for myself to create this corpus: #2079
| * In unit tests projects, the "run test" and "debug test" codelens appears on test methods | ||
| * Clicking runs or debugs the test and prints results to the console | ||
| * Breakpoints in a unit test are hit if you "debug test" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| #### Signature Help | ||
| * Signature Help shows up in a method call after typing `(` | ||
| * Signature help shows documentation for methods and for parameters | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can add something related to the active parameter here, like "Signature Help shows the documentation for the parameter that is currently active"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
No description provided.