Skip to content

Conversation

@rchande
Copy link

@rchande rchande commented Feb 7, 2018

No description provided.

@rchande
Copy link
Author

rchande commented Feb 7, 2018

* Standalone csproj
* Directory containing .sln file that references csprojs--projects should be loaded
* .NET Core/.NET Standard csproj
* (Windows) Desktop .NET projects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always get a bunch of feedback on Unity projects. Should we add something there too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I've typically validated Unity projects.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure--do you have any examples of unity projects people edit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent some pointers in email.

Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Should there be scenario for running/debugging unit tests?

@rchande
Copy link
Author

rchande commented Feb 28, 2018

@DustinCampbell Done--I made the section about unit tests more obvious.

Copy link

@TheRealPiotrP TheRealPiotrP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but we should have a strategy for how the various project types are obtained. I worry we'll waste a bunch of time building up the pre-conditions...

If you look in "Output > Omnisharp Log" a bunch of information should be printed about what copy of MSBuild was used and what projects were load

Project types to test:
* Standalone csproj

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we expect these projects to come from?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a workitem for myself to create this corpus: #2079

* In unit tests projects, the "run test" and "debug test" codelens appears on test methods
* Clicking runs or debugs the test and prints results to the console
* Breakpoints in a unit test are hit if you "debug test"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rchande Should we mention about "run all tests" and "debug all tests" codelens that was recently added (#1961) ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

#### Signature Help
* Signature Help shows up in a method call after typing `(`
* Signature help shows documentation for methods and for parameters

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add something related to the active parameter here, like "Signature Help shows the documentation for the parameter that is currently active"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rchande rchande merged commit 6f821f5 into dotnet:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants