Skip to content

Make hover test more reliable #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Make hover test more reliable #2023

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9816f82
wait for file addition
Feb 8, 2018
f718425
Merge branch 'master' of https://github.com/omnisharp/omnisharp-vscod…
Feb 8, 2018
1711ac0
fix merge issues'
Feb 8, 2018
4017db7
add log
Feb 8, 2018
7c78026
Add more log
Feb 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 24 additions & 15 deletions test/integrationTests/hoverProvider.integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@ import testAssetWorkspace from './testAssets/testAssetWorkspace';
import { RequestQueueCollection } from '../../src/omnisharp/requestQueue';
import { OmniSharpServer } from '../../src/omnisharp/server';
import { omnisharp } from '../../src/omnisharp/extension';
import { requestWorkspaceInformation } from '../../src/omnisharp/utils';
import { file } from 'tmp';

const chai = require('chai');
chai.use(require('chai-arrays'));
chai.use(require('chai-fs'));
const chai = require('chai');
chai.use(require('chai-arrays'));
chai.use(require('chai-fs'));

suite(`Hover Provider: ${testAssetWorkspace.description}`, function() {
suiteSetup(async function() {
Expand All @@ -27,13 +29,12 @@ suite(`Hover Provider: ${testAssetWorkspace.description}`, function() {
}

await csharpExtension.exports.initializationFinished;
await omnisharp.restart();
});

test("Hover returns structured documentation with proper newlines", async function () {
test("Hover returns structured documentation with proper newlines", async function () {

let program =
`using System;
let program =
`using System;
namespace Test
{
class testissue
Expand All @@ -49,16 +50,24 @@ namespace Test
}
}
}`;
let fileUri = await testAssetWorkspace.projects[0].addFileWithContents("test1.cs", program);
let fileUri = await testAssetWorkspace.projects[0].addFileWithContents("test1.cs", program);
console.log(fileUri);
await vscode.commands.executeCommand("vscode.open", fileUri);

await omnisharp.waitForEmptyEventQueue();

await vscode.commands.executeCommand("vscode.open", fileUri);
// Wait for the file to appear in the O# Workspace
while (true) {
let info = await requestWorkspaceInformation(omnisharp);
console.log(info.MsBuild.Projects[0].SourceFiles);
if (info.MsBuild.Projects[0].SourceFiles.find(s => s.endsWith("test1.cs"))) {
break;
}
await new Promise(resolve => setTimeout(resolve, 500));
}

let c = await vscode.commands.executeCommand("vscode.executeHoverProvider", fileUri,new vscode.Position(10,29));
let c = await vscode.commands.executeCommand("vscode.executeHoverProvider", fileUri, new vscode.Position(10, 29));

let answer:string =
`Checks if object is tagged with the tag.
let answer: string =
`Checks if object is tagged with the tag.

Parameters:

Expand All @@ -68,7 +77,7 @@ Parameters:
Returns true if object is tagged with tag.`;
expect(c[0].contents[0].value).to.equal(answer);
});

teardown(async () => {
await testAssetWorkspace.cleanupWorkspace();
});
Expand Down