Skip to content

Conversation

@akshita31
Copy link
Contributor

@akshita31 akshita31 commented May 10, 2018

  1. Extracted a common getVSCodewithconfig function to be used by the tests.
  2. Added the 'getVsCode` helper in the information message observer tests.
  3. Added updateConfig function to be used with the fake vscode

@akshita31 akshita31 changed the title A little refactoring of the information message observer test and option test Refactoring of the information message observer test and option test May 10, 2018
@codecov
Copy link

codecov bot commented May 10, 2018

Codecov Report

Merging #2277 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2277   +/-   ##
=======================================
  Coverage   59.81%   59.81%           
=======================================
  Files          78       78           
  Lines        3773     3773           
  Branches      543      543           
=======================================
  Hits         2257     2257           
  Misses       1343     1343           
  Partials      173      173
Flag Coverage Δ
#integration 50.86% <ø> (ø) ⬆️
#unit 83.45% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5acc418...6ed222b. Read the comment docs.

@akshita31 akshita31 merged commit a7d392c into dotnet:master May 10, 2018
@akshita31 akshita31 deleted the clean_up_tests branch May 10, 2018 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants