Clear the OmniSharp channel before restarting the server #2318
Conversation
akshita31
requested review from
DustinCampbell,
TheRealPiotrP,
colombod and
rchande
Codecov Report
@@ Coverage Diff @@
## master #2318 +/- ##
==========================================
+ Coverage 59.75% 59.79% +0.04%
==========================================
Files 83 83
Lines 3764 3768 +4
Branches 547 547
==========================================
+ Hits 2249 2253 +4
+ Misses 1348 1347 -1
- Partials 167 168 +1
Continue to review full report at Codecov.
|
src/omnisharp/server.ts
Outdated
|
|
||
| try { | ||
| let launchResult = await launchOmniSharp(cwd, args, launchInfo, this.platformInfo, options); | ||
| this.eventStream.post(new ObservableEvents.ShowOmniSharpChannel()); |
There was a problem hiding this comment.
This would show the OmniSharp log everytime the user launches C# for VS Code? I think that would be very annoying. I would recommend against that behavior.
There was a problem hiding this comment.
I don't think we should be showing the OmniSharp Log channel everytime the user launches C# for VS Code.
EDIT: To be clear, I'm fine with clearing the log when restarting. But showing the log every time OmniSharp launches will likely be very annoying to users.
|
@DustinCampbell Understood your concern. Removed the show thing. Now this PR just clears the omnisharp channel whenever there is a restart. |
akshita31
changed the title
|
thank you - this is a very welcome change! |
3 participants
Clear the
Omnisharp logchannel when we restart the server to avoid having to navigate through logs from the previous start.A relevant unit test also added to the OmnisharpChannelObserver