Remove istanbul-combine #2322
Merged
Remove istanbul-combine #2322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshita31
requested review from
DustinCampbell,
TheRealPiotrP,
colombod,
jonsequitur and
rchande
Codecov Report
@@ Coverage Diff @@
## master #2322 +/- ##
=======================================
Coverage 59.79% 59.79%
=======================================
Files 83 83
Lines 3768 3768
Branches 547 547
=======================================
Hits 2253 2253
Misses 1347 1347
Partials 168 168
Continue to review full report at Codecov.
|
colombod
approved these changes
May 18, 2018
Member
colombod
left a comment
colombod
left a comment
There was a problem hiding this comment.
Approved with metal from El Diablo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here suggests that istanbul-combine should be deprecated in favor of
istanbul report. Also istanbul-combine depends on an older version of minimatch which has a RegExp DoS vulnerability.