Skip to content

Conversation

@akshita31
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 31, 2018

Codecov Report

Merging #2448 into master will decrease coverage by 1.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2448      +/-   ##
==========================================
- Coverage   64.81%   63.63%   -1.18%     
==========================================
  Files          88       88              
  Lines        4007     4007              
  Branches      565      567       +2     
==========================================
- Hits         2597     2550      -47     
- Misses       1249     1294      +45     
- Partials      161      163       +2
Flag Coverage Δ
#integration 52.67% <ø> (-1.84%) ⬇️
#unit 84.71% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/features/definitionMetadataDocumentProvider.ts 43.75% <0%> (-18.75%) ⬇️
src/features/abstractProvider.ts 85.71% <0%> (-14.29%) ⬇️
src/common.ts 69.66% <0%> (-10.12%) ⬇️
src/features/changeForwarding.ts 62.96% <0%> (-7.41%) ⬇️
src/statusBarItemAdapter.ts 46.66% <0%> (-6.67%) ⬇️
src/omnisharp/requestQueue.ts 72.72% <0%> (-6.07%) ⬇️
src/omnisharp/delayTracker.ts 68.42% <0%> (-5.27%) ⬇️
src/omnisharp/server.ts 72.43% <0%> (-4.6%) ⬇️
src/observers/CsharpLoggerObserver.ts 96.36% <0%> (-3.64%) ⬇️
src/features/dotnetTest.ts 11.32% <0%> (-2.84%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77d89f...d1d8453. Read the comment docs.

Copy link

@rchande rchande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once this passes CI

Use an old version

use another version

Yet another omnisharp version

using next version of yet another version
@akshita31 akshita31 merged commit 82be5e1 into dotnet:master Aug 1, 2018
@akshita31 akshita31 deleted the use_not_latest branch August 1, 2018 18:10
@DustinCampbell
Copy link
Member

How is this the "in box" OmniSharp. The version listed in the package.json is 1.30.1

@akshita31
Copy link
Contributor Author

I initially started with that, but then later we switched to the more recent versions. Apologies for the confusion.

@DustinCampbell
Copy link
Member

FWIW, PR titles are editable. 😄

@akshita31 akshita31 changed the title Using the in box omnisharp for integration tests Using a particular omnisharp and not "latest" for integration tests Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants