Fix project detection to handle many CS files #2721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
cc @akshita31 |
Contributor
|
Looks good to me. Thanks!! |
akshita31
approved these changes
Nov 30, 2018
Codecov Report
@@ Coverage Diff @@
## master #2721 +/- ##
==========================================
- Coverage 65.54% 65.38% -0.17%
==========================================
Files 101 101
Lines 4351 4353 +2
Branches 635 635
==========================================
- Hits 2852 2846 -6
- Misses 1317 1323 +6
- Partials 182 184 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2720
It seems that project files should take priority over CS files - this solution will look for project files first (up to the limit) and then look for CS files (up to the limit) so the project files come first.
It might make sense to skip the CS detection altogether if project files are located but I wanted to keep everything as close to the original implementation as possible to not break any existing use cases.