Skip to content

Conversation

@NTaylorMullen
Copy link

@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #2975 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2975   +/-   ##
=======================================
  Coverage   89.89%   89.89%           
=======================================
  Files          59       59           
  Lines        1583     1583           
  Branches       89       89           
=======================================
  Hits         1423     1423           
  Misses        149      149           
  Partials       11       11
Flag Coverage Δ
#integration 100% <ø> (ø) ⬆️
#unit 89.89% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a26dce...8059655. Read the comment docs.

Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback

Copy link

@rchande rchande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let me know when you're ready for this to be merged.

@NTaylorMullen
Copy link
Author

Feel free to merge once the build passes, it's good to go!

@rchande rchande merged commit 3a2f032 into dotnet:master Apr 11, 2019
@NTaylorMullen NTaylorMullen deleted the nimullen/330/331 branch April 11, 2019 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants