Update minimum Mono version to 6.6.0 #3539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to match the OmniSharp-Roslyn required Mono version.
Member
Author
|
@filipw Would there be any reason to allow the use of a earlier version? |
Contributor
|
no makes sense to me 👌 |
filipw
approved these changes
Jan 30, 2020
Contributor
|
the server allows 6.4.0 by the way, when that change was made 6.6.0 was still in pre-release but it should be aligned at 6.6.0 since embedded mono is 6.6.0 based |
Codecov Report
@@ Coverage Diff @@
## master #3539 +/- ##
======================================
Coverage 89.8% 89.8%
======================================
Files 59 59
Lines 1589 1589
Branches 89 89
======================================
Hits 1427 1427
Misses 151 151
Partials 11 11
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to match the OmniSharp-Roslyn required Mono version. (https://github.com/OmniSharp/omnisharp-roslyn/blob/1e93b0748fd7d2337011a9a674ae682571280486/build.json#L5)