Skip to content

Schema for pipe transport options. #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 27, 2016
Merged

Schema for pipe transport options. #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
715b91b
Schema for pipe transport options.
rajkumar42 May 25, 2016
32514ad
Incorporating code review comments.
rajkumar42 May 26, 2016
da83612
Updating package dependency for OpenDebugAD7.
rajkumar42 May 27, 2016
f1b298d
Merge branch 'dev' into rajkumar42/pipelaunchschema
rajkumar42 May 27, 2016
2372812
Updating the version of MIEngine.
rajkumar42 May 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion coreclr-debug/NuGet.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
<clear />
<add key="api.nuget.org" value="https://api.nuget.org/v3/index.json" />
<!-- This dependency can be commented out once we push packages to nuget for a real release -->
<add key="coreclrdebug" value="https://www.myget.org/F/coreclr-debug/api/v3/index.json" />
<add key="coreclrdebug" value="https://www.myget.org/F/coreclr-debug/api/v3/index.json" />
</packageSources>
</configuration>
92 changes: 92 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,98 @@
"type": "string"
},
"default": []
},
"pipeTransport": {
"type": "object",
"description": "When present, this tells the debugger to connect to a remote computer using another executable as a pipe that will relay standard input/output between VS Code and the .NET Core debugger backend executable (clrdbg).",
"default": {
"pipeProgram": "enter the fully qualified path for the pipe program name, for example 'c:\\tools\\plink.exe'",
"pipeArgs": []
},
"properties" : {
"pipeProgram": {
Copy link
Contributor

@gregg-miskelly gregg-miskelly May 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the MIEngine search PATH if this is not a full file path? Or does it need to be a file path? Probably worth calling out in the description either way.

Copy link
Contributor Author

@rajkumar42 rajkumar42 May 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

"type": "string",
"description": "The fully qualified pipe command to execute.",
"default": "enter the fully qualified path for the pipe program name, for example 'c:\\tools\\plink.exe'"
},
"pipeArgs": {
"type": "array",
"description": "Command line arguments passed to the pipe program.",
"items": {
"type": "string"
},
"default": []
Copy link
Contributor

@gregg-miskelly gregg-miskelly May 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you missing?

              "items": { 
                "type": "string" 
              },

Copy link
Contributor Author

@rajkumar42 rajkumar42 May 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

},
"windows": {
"type": "object",
"description": "Windows-specific pipe launch configuration options",
"default": {
"pipeProgram": "enter the fully qualified path for the pipe program name, for example 'c:\\tools\\plink.exe'",
"pipeArgs": []
},
"properties": {
"pipeProgram": {
"type": "string",
"description": "The fully qualified pipe command to execute.",
"default": "enter the fully qualified path for the pipe program name, for example 'c:\\tools\\plink.exe'"
},
"pipeArgs": {
"type": "array",
"description": "Command line arguments passed to the pipe program.",
"items": {
"type": "string"
},
"default": []
}
}
},
"osx": {
"type": "object",
"description": "OSX-specific pipe launch configuration options",
"default": {
"pipeProgram": "enter the fully qualified path for the pipe program name, for example '/usr/bin/ssh'",
"pipeArgs": []
},
"properties": {
"pipeProgram": {
"type": "string",
"description": "The fully qualified pipe command to execute.",
"default": "enter the fully qualified path for the pipe program name, for example '/usr/bin/ssh'"
},
"pipeArgs": {
"type": "array",
"description": "Command line arguments passed to the pipe program.",
"items": {
"type": "string"
},
"default": []
}
}
},
"linux": {
"type": "object",
"description": "Linux-specific pipe launch configuration options",
"default": {
"pipeProgram": "enter the fully qualified path for the pipe program name, for example '/usr/bin/ssh'",
"pipeArgs": []
},
"properties": {
"pipeProgram": {
"type": "string",
"description": "The fully qualified pipe command to execute.",
"default": "enter the fully qualified path for the pipe program name, for example '/usr/bin/ssh'"
},
"pipeArgs": {
"type": "array",
"description": "Command line arguments passed to the pipe program.",
"items": {
"type": "string"
},
"default": []
}
}
}
}
}
}
},
Expand Down
4 changes: 2 additions & 2 deletions src/coreclr-debug/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,8 +333,8 @@ function createProjectJson(targetRuntime: string): any
},
dependencies: {
"Microsoft.VisualStudio.clrdbg": "14.0.25320-preview-3008693",
"Microsoft.VisualStudio.clrdbg.MIEngine": "14.0.30520-preview-9",
"Microsoft.VisualStudio.OpenDebugAD7": "1.0.20520-preview-3",
"Microsoft.VisualStudio.clrdbg.MIEngine": "14.0.30527-preview-1",
"Microsoft.VisualStudio.OpenDebugAD7": "1.0.20527-preview-1",
"NETStandard.Library": "1.5.0-rc2-24027",
"Newtonsoft.Json": "7.0.1",
"Microsoft.VisualStudio.Debugger.Interop.Portable": "1.0.1",
Expand Down