Adding attach process picker. #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature will light up when the required vscode features are available in stable release.
package.json
Outdated
| "onCommand:o.showOutput", | ||
| "onCommand:dotnet.restore", | ||
| "onCommand:csharp.downloadDebugger", | ||
| "onCommand:debugger.pickProcess", |
Contributor
There was a problem hiding this comment.
'debugger.pickProcess' sounds likely to clash with other extensions. Should this be 'csharp.debuggerPickProcess' so something like that?
Contributor
|
Do we want this in for the next release or not? Rajkumar and I talked about it in person: our opinion - this feels like it isn't 100% baked, so we will put it into dev after we next merge dev->master (hopefully very soon). |
- Changing the command to csharp.listProcess. - Sorting the process, such that dotnet process are shown at the top.
gregg-miskelly
pushed a commit
to gregg-miskelly/vscode-csharp
that referenced
this pull request
Jun 16, 2016
* Adding attach process picker. This feature will light up when the required vscode features are available in stable release. * Incorporating code review comments. - Changing the command to csharp.listProcess. - Sorting the process, such that dotnet process are shown at the top.
gregg-miskelly
added a commit
that referenced
this pull request
Jun 17, 2016
* Adding attach process picker. This feature will light up when the required vscode features are available in stable release. * Incorporating code review comments. - Changing the command to csharp.listProcess. - Sorting the process, such that dotnet process are shown at the top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature will light up when the required vscode features are available in stable release.