-
Notifications
You must be signed in to change notification settings - Fork 728
Merge dev into master #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checkin adds 'env' to the launch.json schema, and it adds a "ASPNETCORE_ENVIRONMENT=Development" environment variable by default. This completes the fix for #172
Update coreclr-debug packages for post rc2 work
It is a web application if it has any dependencies on microsoft.aspnetcore.server.*
Creating launch for web or console.
[Dev] Add 'ASPNETCORE_ENVIRONMENT' to default ASP.NET launch options
Merge master into dev
* Schema for pipe transport options. * Incorporating code review comments. * Updating package dependency for OpenDebugAD7. * Updating the version of MIEngine.
Discover and execute (both run and debug) xunit test in VS Code
This should address the race condition in the decompress module reported at kevva/decompress#28. This should fix #202.
Update decompress module to 4.0.0
Update OmniSharp to 1.9-beta4
Merge master into dev
Update version to 1.1.1
With this checkin, we now support an 'externalConsole' launch option. This option is specified by default for console projects. This completes the fix for: #175
This change fixes the use of the decompress (which changed its API shape in 4.0.0), and passes a VS Code OutputChannel into the downloading logic to surface logging.
Update namespace of test endpoints to V2
Fix OmniSharp download and improve logging
isOnPath calls existsSync, which was not handling ENOTDIR. This can arise if a portion of a path is not a directory, such as /dir1/dir2/<executable>/foo/bar. existsSync should return false in these cases. Additionally, this adds a try/catch to isOnPath that should catch all other errors from existsSync and treat them as basic failures for that particular path segment.
Improve error handling for 'isOnPath'
This updates the clrdbg package to the 25406 build. This includes fixes for Win7 expression evulation and the System.Task breaking change. This addresses: #258 This also the MIEngine to pull in microsoft/MIEngine#353 Lastly this disables the external console by default. We decided to have it off by default as we have seen some issues with it on OSX (ex: not always closing when the target exits), and we are hoping it will be possible soon to use the new VS Code console window instead. So we decided to turn it off by default, at least for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checkin merges dev into master as part of releasing v1.1.4 to the store.