Adding pipeCwd to schema. #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
package.json
Outdated
| "properties" : { | ||
| "pipeCwd": { | ||
| "type": "string", | ||
| "description": "The fully qualified path where the pipe command to execute.", |
Contributor
There was a problem hiding this comment.
The description sentence sounds grammatically incorrect. Maybe something like "The fully qualified path to the working directory for the pipe program"?
Contributor
|
NOTE: This might have been your plan already, but I would suggest also updating the MIEngine/OpenDebugAD7 versions in this PR as well. |
Contributor
|
Otherwise LGTM |
Contributor
|
LGTM |
Contributor
Author
|
@gregg-miskelly yep thats the plan. I need to wait for other CR and builds to complete. |
Contributor
|
👍 |
Adding the option to provide environment variables to the pipe program.
Contributor
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.