Remove myget feed from NuGet.config #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are waiting on a response from the myget.org team to understand the priority of this to understand if we should fix it now, or just before we release the next time. |
| <clear /> | ||
| <add key="api.nuget.org" value="https://api.nuget.org/v3/index.json" /> | ||
| <!-- This dependency can be commented out once we push packages to nuget for a real release --> | ||
| <add key="coreclrdebug" value="https://www.myget.org/F/coreclr-debug/api/v3/index.json" /> |
There was a problem hiding this comment.
do we want to comment this out instead of delete it? Are we still planning on pushing daily builds to myget?
There was a problem hiding this comment.
We are still going to push daily builds to myget, but my hope is that I can get git to leave this commit in the master branch by manually resolving the conflict if we merge back to master.
When we released the extension, I forgot to remove the myget feed from our NuGet.config, I was assuming this wouldn't really matter since nuget.org came first in the list, by the myget folks reported a traffic spike, so I am assuming we should really remove this.
gregg-miskelly
force-pushed
the
RemoveMyGetFeed
branch
from
7e57e64 to
82062ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we released the extension, I forgot to remove the myget feed from our NuGet.config,
I was assuming this wouldn't really matter since nuget.org came first in the list, by
the myget folks reported a traffic spike, so I am assuming we should really remove this.