Skip to content

Conversation

@wesrupert
Copy link
Contributor

Add flag to disable logging module load events to the console. Since everything (including debuggee output) is logged to the debug output window in normal scenarios, module load events can cause the log to become cluttered fairly quickly. Setting this flag to false in launch.json will remove the module load events from the log.

@wesrupert
Copy link
Contributor Author

@caslan
Copy link
Contributor

caslan commented Jun 14, 2016

Instead of doing this, should we have a section for controlling output options in general? i.e. Exception messages, step filtering messages, module load / unload messages, thread exit messages, program output

@chuckries
Copy link
Contributor

I'd be fine with that, either way this option needs to be in both sections, launch and attach.

@chuckries
Copy link
Contributor

👍

@rajkumar42
Copy link
Contributor

:shipit:

@gregg-miskelly
Copy link
Contributor

NOTE: You might want to hold off actually completing this PR until post escrow when you can insert a new OpenDebugAD7 that has your changes. Though if you really would like to complete it now I will not object as it doesn't break anything - it just will not actually work.

@gregg-miskelly
Copy link
Contributor

@jacdavis FYI in case you want this in the C++ extension also

@gregg-miskelly
Copy link
Contributor

LGTM

@wesrupert
Copy link
Contributor Author

@gregg-miskelly RE: your note. I'll hold on to this PR for now; it looks like there's a few more logging features planned so it makes sense to wait and add them in one go.

@wesrupert
Copy link
Contributor Author

@caslan @gregg-miskelly @chuckries Here's the additional flags.

@caslan
Copy link
Contributor

caslan commented Jun 16, 2016

LGTM

1 similar comment
@gregg-miskelly
Copy link
Contributor

LGTM

@wesrupert wesrupert closed this Jun 28, 2016
@wesrupert wesrupert reopened this Jun 28, 2016
@dnfclas
Copy link

dnfclas commented Jun 28, 2016

Hi @wesrupert, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants