-
Notifications
You must be signed in to change notification settings - Fork 727
Add logModuleLoadEvents launch option configuration #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Instead of doing this, should we have a section for controlling output options in general? i.e. Exception messages, step filtering messages, module load / unload messages, thread exit messages, program output |
|
I'd be fine with that, either way this option needs to be in both sections, launch and attach. |
|
👍 |
|
|
|
NOTE: You might want to hold off actually completing this PR until post escrow when you can insert a new OpenDebugAD7 that has your changes. Though if you really would like to complete it now I will not object as it doesn't break anything - it just will not actually work. |
|
@jacdavis FYI in case you want this in the C++ extension also |
|
LGTM |
|
@gregg-miskelly RE: your note. I'll hold on to this PR for now; it looks like there's a few more logging features planned so it makes sense to wait and add them in one go. |
|
@caslan @gregg-miskelly @chuckries Here's the additional flags. |
|
LGTM |
1 similar comment
|
LGTM |
|
Hi @wesrupert, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
Add flag to disable logging module load events to the console. Since everything (including debuggee output) is logged to the debug output window in normal scenarios, module load events can cause the log to become cluttered fairly quickly. Setting this flag to false in launch.json will remove the module load events from the log.